[VL] Support Cast between TIMESTAMP and TIMESTAMP_NTZ - #12654
Open
Mariamalmesfer wants to merge 1 commit into
Open
[VL] Support Cast between TIMESTAMP and TIMESTAMP_NTZ#12654Mariamalmesfer wants to merge 1 commit into
Mariamalmesfer wants to merge 1 commit into
Conversation
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-cast-timestamp-utc-support
branch
from
July 29, 2026 21:54
787883d to
fcd4b69
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-cast-timestamp-utc-support
branch
from
August 3, 2026 10:54
fcd4b69 to
2501240
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
Hi @rui-mo, could you take a look when you get the chance? Thanks! |
rui-mo
reviewed
Aug 4, 2026
| case Minute(child, _) => containsNTZ(child.dataType) | ||
| case Second(child, _) => containsNTZ(child.dataType) | ||
| case TimestampAdd(_, _, child, _) => containsNTZ(child.dataType) | ||
| case c: Cast if !containsNTZ(c.dataType) => containsNTZ(c.child.dataType) |
Contributor
There was a problem hiding this comment.
This would allow all non-timestamp_ntz types to be cast to timestamp_ntz. While I assume the supported cases are still limited. Could you please confirm?
Contributor
Author
There was a problem hiding this comment.
Yes, that's correct fixed required both guards to check TimestampType
Mariamalmesfer
force-pushed
the
ts-ntz-cast-timestamp-utc-support
branch
from
August 5, 2026 09:54
2501240 to
cce03eb
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-cast-timestamp-utc-support
branch
from
August 5, 2026 11:38
cce03eb to
554debc
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@rui-mo could you take another look? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CAST(timestamp AS timestamp_ntz) and CAST(timestamp_ntz AS timestamp)
to run natively in the Velox backend instead of falling back to Spark.
Velox PR: facebookincubator/velox#17920